On Oct 13, 2020, at 1:14 AM, Matt Coleman <mcoleman@datto.com> wrote:
+ if (priv->wmiVersion == HYPERV_WMI_VERSION_V2) + requestedState = MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED_BUT_OFFLINE; ... + MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED_BUT_OFFLINE = 6,
I realized I named this after the description of the (related) Msvm_ComputerSystem EnabledState value, not the RequestStateChange() method’s RequestedState parameter that this enum actually represents. https://docs.microsoft.com/en-us/windows/win32/hyperv_v2/msvm-computersystem... https://docs.microsoft.com/en-us/windows/win32/hyperv_v2/requeststatechange-... If another squashed change is ok, this should be “MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_OFFLINE” instead of “MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED_BUT_OFFLINE”. I feel like we’ve discussed a lot of changes getting squashed into this patchset and that I should probably just revise it all and send v3. -- Matt