Re: [libvirt PATCH v2 0/4] Enable copy/paste for vnc displays

On 5/9/22 11:06 AM, Marc-André Lureau wrote: > Hi Jonathon > > On Thu, Mar 24, 2022 at 11:26 PM Jonathon Jongsma <jjongsma(a)redhat.com > <mailto:jjongsma@redhat.com>> wrote: > >     This patch series enables support for the qemu-vdagent character >     device which >     enables copy/paste support between guest and client when using vnc >     graphics. > >     The guest must be configured with something like the following: > >          <channel type='qemu-vdagent'> >            <source> >              <clipboard copypaste='yes'/> >              <mouse mode='client'/> >            </source> >            <target type='virtio' name='com.redhat.spice.0'/> >          </channel> > >     Copy/paste sync requires a vnc client that has support for >     copy/paste commands. >     Currently virt-viewer does not work, but the version of tigervnc >     provided by >     fedora (executable name 'vncviewer') does work. > >     More details about this device on Gerd's blog: >     https://www.kraxel.org/blog/2021/05/qemu-cut-paste/ >     <https://www.kraxel.org/blog/2021/05/qemu-cut-paste/> > >     For now I have left the target to be configurable to match the > spicevmc >     channel, although Marc-Andre has suggested to simply hard-code it to >     the virtio >     name com.redhat.spice.0 > >     Changes in v2: >       - change xml syntax to use <clipboard> and <mouse> sub-elements of >     <source> >         defined in the same way as they are for the spice display. >       - fix a build failure when apparmor was enabled >       - Add another test for when features are turned off > > > Is there anything missing to merge this? > thanks Thanks for the ping on this. I suppose I was waiting to see if anybody else had any opinions on whether the virtio name should be configurable or not (which you had recommended against), and then it fell off my radar for a little bit. I will push it tomorrow if nobody speaks up before then.