Re: [libvirt] [PATCHv2 2/4] Make virStorageBackendCopyToFD return -errno.

On Mon, Jul 19, 2010 at 09:21:53PM -0400, Laine Stump wrote: > Previously virStorageBackendCopyToFD would simply return -1 on > error. This made the error return from one of its callers inconsistent > (createRawFileOpHook is supposed to return -errno, but if > virStorageBackendCopyToFD failed, createRawFileOpHook would just > return -1). Since there is a useful errno in every case of error > return from virStorageBackendCopyToFD, and since the other uses of > that function ignore the return code (beyond simply checking to see if > it is< 0), this is a safe change. > --- > src/storage/storage_backend.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > ACK,