On Fri, Aug 28, 2020 at 10:08:36 -0400, Masayoshi Mizuma wrote:
From: Masayoshi Mizuma <m.mizuma(a)jp.fujitsu.com>
Block disk hotplug when transient disk option is enabled so far.
Signed-off-by: Masayoshi Mizuma <m.mizuma(a)jp.fujitsu.com>
---
src/qemu/qemu_hotplug.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 2c6c30ce03..1c1b6c3acf 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -1031,6 +1031,12 @@ qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriverPtr driver,
return -1;
}
+ if (disk->transient) {
+ virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
+ _("transient disk hotplug isn't supported"));
+ return -1;
+ }
Please move this up in the series so that it's in place before enabling
the feature.