Re: [libvirt] [PATCH] esx: Split VMX code into a general and an ESX specific part

On 08/05/2010 09:47 AM, Matthias Bolte wrote: > Introduce esxVMX_Context containing functions pointers to > glue both parts together in an generic way. s/an/a/

> > Move the ESX specific part to esx_driver.c. > > This is a step towards making the VMX code reusable in a > potential VMware Workstation and VMware Player driver. > --- >  src/esx/esx_driver.c |  417 ++++++++++++++++++++++++++++++++++++++++++++++- >  src/esx/esx_vmx.c    |  448 +++++--------------------------------------------- >  src/esx/esx_vmx.h    |   71 +++++---- >  tests/vmx2xmltest.c  |   52 ++++++- >  tests/xml2vmxtest.c  |   64 +++++++- >  5 files changed, 611 insertions(+), 441 deletions(-) Looks like the bulk of the patch is code motion and test addition. ACK.