Re: [PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add
Am 11.03.2021 um 09:14 hat Paolo Bonzini geschrieben:
On 10/03/21 18:30, Kevin Wolf wrote:
> Am 10.03.2021 um 15:31 hat Paolo Bonzini geschrieben:
> > On 10/03/21 15:22, Peter Krempa wrote:
> > > I've stumbled upon a regression with this patchset applied:
> > >
> > > error: internal error: process exited while connecting to monitor:
qemu-system-x86_64: -object
memory-backend-ram,id=pc.ram,size=1048576000,host-nodes=0,policy=bind: Invalid parameter
type for 'host-nodes', expected: array
> >
> > This is the magic conversion of "string containing a list of
integers"
> > to "list of integers".
>
> Ah, crap. This one wouldn't have been a problem when converting only
> object-add, and I trusted your audit that user creatable objects don't
> depend on any QemuOpts magic. I should have noticed it, too, of course,
> but during the convertion I didn't have QemuOpts in mind, only QOM and
> QAPI.
Yeah, let's just drop the -object conversion for now. It will just remove a
few patches.
I think it's only patch 29 and 30 that we would have to drop, actually.
Unfortunately, that still removes one of the most immediately useful
features, which is non-scalar properties for -object in the system
emulator. But of course, a lot better than not merging it at all.
Who is going to include this series in the next pull request, Markus
or
myself? The time is ticking for soft freeze.
QOM is probably the right subsystem, so that would be you. Or I can just
merge it myself as long as everyone is fine with it.
Eric has some minor comments that I think could be addressed while
applying the series. Or should I send a v4 for that (and for dropping
patches 29 and 30)?
Kevin