Re: [libvirt] [PATCH 29/29] Require space after cast

On Mon, Apr 23, 2018 at 02:25:26PM +0100, Daniel P. Berrangé wrote: with_spaces=$(git ls-files '*.[chx]' | xargs grep -E '(\([a-zA-Z _]+ \*+|\(((signed|unsigned|long|short|int|char|s?size_t|void) ?)+|switch \(\(vir[a-zA-Z]*Type)\) ([^ );,])' | wc -l) without_spaces=$(git ls-files '*.[chx]' | xargs grep -E '(\([a-zA-Z _]+ \*+|\(((signed|unsigned|long|short|int|char|s?size_t|void) ?)+|switch \(\(vir[a-zA-Z]*Type)\)([^ );,])' | wc -l) total=$(git ls-files '*.[chx]' | xargs grep -E '(\([a-zA-Z _]+ \*+|\(((signed|unsigned|long|short|int|char|s?size_t|void) ?)+|switch \(\(vir[a-zA-Z]*Type)\) ?([^ );,])' | wc -l) printf "Casts with spaces: %.2f%%\nCasts without spaces: %.2f%%\n" $((with_spaces * 100.0 / total)) $((without_spaces * 100.0 / total)) It's kinda hairy, but it works. Except the xdrproc_t cast that Peter pointed out. With that fixed it is actually 52.94% instead of 54.85%. That also shows that the first time I did it, I certainly included the *_t in the regex. I know we've discussed it earlier, and I don't want to repeat myself, but for the sake of keeping it in the conversation; there are spaces around everything except function calls, but in the end it's just a clearer separation. I used to prefer non-spaced casts too, but then I misread some and realized it's similar to arithmetics for example. And before anyone starts shouting at me that it is very subjective and it all depeds on x, y, and z, including your terminal font, I agree, it for sure is. And I also agree that we should not be spending almost any of out time with something that's very close to bikeshedding =) I just want this to be unified across the codebase, and if the consensus is that there should be no spaces, then I'll resend the series with the spaces removed. Just let me know so that I don't send ton of patches for no reason. Have a nice day, Martin