On Thu, May 16, 2013 at 08:40:50PM +0800, Osier Yang wrote:
Changes: * Remove the useless space in "for" statement (e.g. for (i = 0 ; i < something ; i++)
It would be pretty easy to extend build-aux/bracket-spacing.pl to validate correct whitespace around the ';' in for loops.
* Change the function's style to: void foo(bar) { printf("foo is not bar\n"); }
* Don't lose "{}" for "if...else" branches if one of the branch has more than one line block. Example of the old ones: if (a) { printf("a is not funny"); } else printf("a is funny");
* Remove the 1 space before "goto" label.
* Remove the useless blank line(s)
* Add blank line if it can make the code more clear to eyes. --- src/conf/storage_conf.c | 175 ++++++++++++++++++++++++++++-------------------- 1 file changed, 104 insertions(+), 71 deletions(-)
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|