Re: [libvirt] [PATCH 00/13] qemu: Kill some very ugly legacy code
On 04/26/2016 10:21 AM, Pavel Hrdina wrote:
On Tue, Apr 26, 2016 at 03:37:33PM +0200, Peter Krempa wrote:
> Noticed while doing a depth-first search for a different refactor.
ACK series
We should drop QEMU_CAPS_DEVICE from all of libvirt code since this capability
will be always set. Maybe also add a syntax-check to forbit to use
QEMU_CAPS_DEVICE outside of src/qemu/qemu_capabilities.h.
The way we have been doing that is to change the name to X_QEMU_CAPS_DEVICE
once all uses are removed, so it will stick out in newly added code.
And if anyone is motivated, I documented a bunch of other old flags that can
be dropped:
http://wiki.libvirt.org/page/BiteSizedTasks#Remove_unused_QEMU_feature_flags
- Cole