Re: [libvirt PATCH 008/351] meson: src/util/virfile: rewrite virFileActivateDirOverrideForProg

On a Wednesday in 2020, Peter Krempa wrote: > On Wed, Jul 22, 2020 at 10:33:58 +0200, Ján Tomko wrote: > > On a Wednesday in 2020, Peter Krempa wrote: > > > On Thu, Jul 16, 2020 at 11:54:04 +0200, Pavel Hrdina wrote: > > > > With meson we no longer have .libs directory with the actual binary so > > > > we have to take a different approach to detect if running from build > > > > directory. > > > > > > > > This is not as robust as for autotools because if you select --prefix > > > > in the build directory it will incorrectly enable the override as well > > > > but nobody should do that. > > > > > > This wouldn't be that much of a problem as it would end up pointing to > > > the same files. > > > > > > More of a problem is if we falsely assume that the override is not > > > necessary. > > > > > > > That's why I'd rather drop this "override-by-binary-path" approach > > and use the env variable in the "run" script for this. > > That would mandate using ./run even in situations where it was not > required before. > Yes, that's what I meant.