Re: [PATCH v2 3/4] conf: Introduce TCG domain features
On 11/5/21 10:35 AM, Michal Privoznik wrote:
It may come handy to be able to tweak TCG options, in this
specific case the size of translation block cache size (tb-size).
Since we can expect more knobs to tweak let's put them under
common element, like this:
<domain>
<features>
<tcg>
<tb-cache unit='MiB'>128</tb-cache>
</tcg>
</features>
</domain>
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
Tested-by: Kashyap Chamarthy <kchamart(a)redhat.com>
---
docs/formatdomain.rst | 11 +++
docs/schemas/domaincommon.rng | 15 +++-
src/conf/domain_conf.c | 90 +++++++++++++++++++
src/conf/domain_conf.h | 7 ++
src/qemu/qemu_validate.c | 11 +++
.../x86_64-default-cpu-tcg-features.xml | 67 ++++++++++++++
...default-cpu-tcg-features.x86_64-latest.xml | 1 +
tests/qemuxml2xmltest.c | 1 +
8 files changed, 202 insertions(+), 1 deletion(-)
create mode 100644 tests/qemuxml2argvdata/x86_64-default-cpu-tcg-features.xml
create mode 120000
tests/qemuxml2xmloutdata/x86_64-default-cpu-tcg-features.x86_64-latest.xml
Oops, consider this squashed in:
diff --git i/src/conf/domain_conf.c w/src/conf/domain_conf.c
index 496e43dc02..678a434f04 100644
--- i/src/conf/domain_conf.c
+++ w/src/conf/domain_conf.c
@@ -3714,6 +3714,7 @@ void virDomainDefFree(virDomainDef *def)
g_free(def->description);
g_free(def->title);
g_free(def->hyperv_vendor_id);
+ g_free(def->tcg_features);
virBlkioDeviceArrayClear(def->blkio.devices,
def->blkio.ndevices);
Michal