Re: [libvirt] [PATCH 1/2] bhyve: stub for domainResume
On Tue, Apr 08, 2014 at 07:01:33AM +0200, Wojciech Macek wrote:
bhyve does not support suspend nor resume. To enable OpenStack
procedure (create -> resume) use stub for domainResume function.
If domain is running then report success; return failure in all other
cases.
---
src/bhyve/bhyve_driver.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
If bhyve doesn't support suspend or resume, then how is the
'create' method even succeeding. OpenStack will be passing
VIR_DOMAIN_START_PAUSED to that method, so if suspend isn't
support create should have raised an error. As such it should
never get as far as trying to resume. On that basic NACK to
this patch - we shouldn't implement APIs that we know don't
work because it means apps that need to know this won't get
proper error reporting.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|