Re: [libvirt] [PATCH 06/14] Define a wire protocol for talking to the virtlockd daemon
On Wed, Dec 12, 2012 at 11:32:18AM -0700, Eric Blake wrote:
On 12/12/2012 11:14 AM, Michal Privoznik wrote:
> On 11.12.2012 21:41, Daniel P. Berrange wrote:
>> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>>
>> The virtlockd daemon will be responsible for managing locks
>> on virtual machines. Communication will be via the standard
>> RPC infrastructure. This provides the XDR protocol definition
>>
>> * src/locking/lock_protocol.x: Wire protocol for virtlockd
>> * src/Makefile.am: Include lock_protocol.[ch] in virtlockd
>>
>> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
>> ---
>> .gitignore | 1 +
>> cfg.mk | 3 ++
>> src/Makefile.am | 14 ++++++-
>> src/locking/lock_protocol.x | 95 +++++++++++++++++++++++++++++++++++++++++++++
>> 4 files changed, 112 insertions(+), 1 deletion(-)
>> create mode 100644 src/locking/lock_protocol.x
>
> ACK
Should we also tweak src/Makefile.am and add src/lock_protocol-structs
to verify that we don't make any ABI changes to the wire protocol?
Yep, but it'll need a little refactoring of the makefile due
to the conditional builds, so I'll do that as a later patch
Same point about the LXC controller protocol
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|