Re: [libvirt] [PATCH 1/4] virsh: Document limitation of domifstat
On 10/05/2017 10:18 AM, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1497396
The current implementation reads the stats from the host.
However, this doesn't work for all types of interfaces as not all
of them have a representation in the host. For instance,
interface type='user' doesn't.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
tools/virsh.pod | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 00d93781a..632f202e8 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -775,7 +775,9 @@ the guest OS via an agent. If unspecified, 'lease' is the
default.
=item B<domifstat> I<domain> I<interface-device>
-Get network interface stats for a running domain.
+Get network interface stats for a running domain. This might be
+unavailable for some types of interface which don't have
+representation in the host, e.g. user.
What's not really clear is what "don't have representation in the host"
actually means. I really think this needs to be a bit more specific as
to "why" something will fail.
If being too specific is an issue, then consider instead:
The network interface stats are only available for interfaces that have
a physical source interface. This does not include, for example, a
'user' interface type since it is a virtual LAN with NAT to the outside
world.
Curious, are there any others that might qualify?
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
=item B<domif-setlink> I<domain> I<interface-device> I<state>
[I<--config>]