Re: [libvirt] [PATCH v4] storage: Sanitize pool target paths

On 05/25/2010 09:49 AM, Cole Robinson wrote: > Spurious / in a pool target path makes life difficult for apps using the > GetVolByPath, and doing other path based comparisons with pools. This > has caused a few issues for virt-manager users: > > https://bugzilla.redhat.com/show_bug.cgi?id=494005 > https://bugzilla.redhat.com/show_bug.cgi?id=593565 > > Add a new util API which removes spurious /, virFileSanitizePath. Sanitize > target paths when parsing pool XML, and for paths passed to GetVolByPath. > > v2: Leading // must be preserved, properly sanitize path=/, sanitize > away /./ -> / > > v3: Properly handle starting ./ and ending /. > > v4: Drop all '.' handling, just sanitize / for now. ACK - by simplifying the function, it's simpler to verify by code inspection. Thanks for the repeated attempts at this.