On Thu, Aug 28, 2008 at 11:13:03AM +0200, Jim Meyering wrote:
Jim Meyering <jim@meyering.net> wrote:
James Morris <jmorris@namei.org> wrote:
I'm not sure if this is the best way to do this, but it seems to work.
Enable parallel compilation of the repository when running the autobuild script and/or via rpmbuild. ... diff --git a/autobuild.sh b/autobuild.sh ... Good idea. I'll be happy to commit it with something like the following in place of the above:
# If the MAKEFLAGS envvar does not yet include a -j option, # add -jN where N depends on the number of processors. case $MAKEFLAGS in *-j*) ;; *) n=$(getconf _NPROCESSORS_ONLN 2> /dev/null) test "$n" -gt 0 || n=1 n=`expr $n + 1` MAKEFLAGS="$MAKEFLAGS -j$n" export MAKEFLAGS ;; esac
Then you don't have to change the make invocation below, and it won't interfere if someone has already set MAKEFLAGS. Also, not using an absolute path to getconf lets that program work even also when it's installed in a different location.
Finally, I prefer to use N_CPUS+1 as the -j option, here. (personally, I use 2*$N_CPUS+1, but that's probably too aggressive)
Ok?
I'm interpreting non-response as agreement,
Sorry, thought I had replied to your mail already, but obviously forgot. It was fine by me. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|