Re: [libvirt] [PATCH v2 0/2] qemu: Fix specifying CPU model with arm on x86

On 03.10.2014 14:31, Cole Robinson wrote: > Patch 1 is a cleanup, just code movement. > Patch 2 has the goods, details in the commit message > > v2: > Rebase > Generate with --diff-algorithm=patience, makes patch #1 clearer > > Cole Robinson (2): > qemu_command: Split qemuBuildCpuArgStr > qemu: Don't compare CPU against host for TCG > > src/qemu/qemu_command.c | 202 > ++++++++++++--------- > .../qemuxml2argv-aarch64-virt-default-nic.args | 3 +- > .../qemuxml2argv-aarch64-virt-default-nic.xml | 3 + > .../qemuxml2argv-aarch64-virt-virtio.args | 3 +- > .../qemuxml2argv-aarch64-virt-virtio.xml | 3 + > .../qemuxml2argvdata/qemuxml2argv-cpu-exact1.args | 2 +- > tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.xml | 4 +- > .../qemuxml2argv-cpu-exact2-nofallback.args | 2 +- > .../qemuxml2argv-cpu-exact2-nofallback.xml | 4 +- > .../qemuxml2argvdata/qemuxml2argv-cpu-exact2.args | 2 +- > tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.xml | 4 +- > .../qemuxml2argv-cpu-fallback.args | 2 +- > .../qemuxml2argvdata/qemuxml2argv-cpu-fallback.xml | 4 +- > .../qemuxml2argv-cpu-minimum1.args | 2 +- > .../qemuxml2argvdata/qemuxml2argv-cpu-minimum1.xml | 4 +- > .../qemuxml2argv-cpu-minimum2.args | 2 +- > .../qemuxml2argvdata/qemuxml2argv-cpu-minimum2.xml | 4 +- > .../qemuxml2argv-cpu-nofallback.xml | 2 +- > .../qemuxml2argvdata/qemuxml2argv-cpu-strict1.args | 2 +- > .../qemuxml2argvdata/qemuxml2argv-cpu-strict1.xml | 4 +- > .../qemuxml2argv-graphics-spice-timeout.args | 2 +- > .../qemuxml2argv-graphics-spice-timeout.xml | 4 +- > .../qemuxml2argv-pseries-cpu-exact.args | 4 +- > tests/qemuxml2argvtest.c | 21 ++- > .../qemuxml2xmlout-graphics-spice-timeout.xml | 4 +- > 25 files changed, 166 insertions(+), 127 deletions(-) > ACK series Michal