Re: [libvirt] [PATCH 2/3] cpu: Drop generic driver
On Fri, Jun 24, 2016 at 07:36:01PM +0200, Jiri Denemark wrote:
Pretending (partial) support for something we don't understand is
risky.
Reporting a failure is much better.
I agree that pretending support is risky, but I'm not sure about this. For
example it seems that someone uses libvirt on VIR_ARCH_OR32 (commit c88bf5726)
which should be probably included in cpu_arm driver. There are also some other
archs (VIR_ARCH_ALPHA, VIR_ARCH_PPCEMB, VIR_ARCH_SH4, VIR_ARCH_SH4EB,
VIR_ARCH_SPARC and VIR_ARCH_SPARC64 qemu_domain.c) that wouldn't be supported.
I'm not an expert in this area, I'm just asking to make sure that we don't
break anything by removing the cpu_generic driver.
Pavel