Re: [Libvir] [PATCH] qemu_conf.h: Avoid dubious signed one-bit bitfield

On Thu, Nov 15, 2007 at 03:32:21AM -0500, Jim Paris wrote:

Signed one-bit bitfields are odd (values are 0 and -1?). The code doesn't test for == 1, so it's not currently broken, but it's fragile. (Noticed by Sparse).

Okay both changes makes sense, thanks for raising those and sending patches ! Applied and commited to CVS, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/