Re: [libvirt-jenkins-ci PATCH] dco: build and publish a container image for DCO check

On Wed, Apr 08, 2020 at 04:54:17PM +0200, Andrea Bolognani wrote: > On Wed, 2020-04-08 at 15:26 +0100, Daniel P. Berrangé wrote: > > On Wed, Apr 08, 2020 at 04:21:31PM +0200, Andrea Bolognani wrote: > > > On Wed, 2020-04-08 at 12:54 +0100, Daniel P. Berrangé wrote: > > > > + - docker push ${CI_REGISTRY_IMAGE}/${NAME}:${CI_COMMIT_REF_SLUG} > > > > > > I'm not super happy about returning to the image:master naming > > > convention, because most tooling around containers will expect the > > > tag name to be 'latest' and we had just recently managed to adopt it > > > throughout, but of course we need to make sure containers build off > > > branches do not overwrite the known good image built from master... > > > > We could have conditional logic that changes it to "latest" if > > $CI_COMMIT_REF_SLUG == "master" > > If that logic doesn't end up being too complicated and hard to > maintain, I would certainly like that. It doesn't appear possible todo this after all. I can use shell magic to pick "latest" in the script: section, but I need the same logic later for the "image:" tag in the "check-dco" job, and there's no way to achieve that AFAICT.