Re: [libvirt] [PATCH v4 04/15] qemu_domain: Track if domain remembers original owner
On 11/14/18 7:44 AM, Michal Privoznik wrote:
For metadata locking we might need an extra fork() which given
latest attempts to do fewer fork()-s is suboptimal. Therefore,
there will be a qemu.conf knob to enable or this feature. But
or disable or just use "{en|dis}able" if you don't want to reformat all
the lines.
since the feature is actually not metadata locking itself rather
than remembering of the original owner of the file this is named
as 'rememberOwner'. But patches for that feature are not even
posted yet so there is actually no qemu.conf entry in this patch
nor a way to enable this feature.
Even though this is effectively a dead code for now it is still
desired.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_conf.h | 1 +
src/qemu/qemu_domain.c | 7 +++++++
src/qemu/qemu_domain.h | 3 +++
src/qemu/qemu_process.c | 3 +++
4 files changed, 14 insertions(+)
I suppose we could just create the @priv entry and leave @cfg for later,
but I'm fine with this anyway.
Thanks - I know it's a pain, but I'm sure it'd be even more painful to
get a review on a larger patch series which would actually set/use the
knob as you expect.
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John