Re: [libvirt] [PATCH v2 2/5] remote: Implement virDomainFSFreeze and virDomainFSThaw

14 Mar 2014


      Hi Daniel,
Thank you for the review.
...
...
@@ -5262,5 +5271,17 @@ enum remote_procedure {
      * @generate: both
      * @acl: none
      */
-    REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED = 333
+    REMOTE_PROC_DOMAIN_EVENT_CALLBACK_DEVICE_REMOVED = 333,
+
+    /**
+     * @generate: both
+     * @acl: domain:write
+     */
+    REMOTE_PROC_DOMAIN_FSFREEZE = 334,
+
+    /**
+     * @generate: both
+     * @acl: domain:write
+     */
+    REMOTE_PROC_DOMAIN_FSTHAW = 335
I think this is a case where we should invent a new permission name.
Add  VIR_ACCESS_PERM_DOMAIN_FS_FREEZE to src/access/viraccessperm.h
and use it for both of these RPC calls. We should also make the
existing VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag for snapshot APIs
uses this new permission.
I see. I will add the new acl for this and for
VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE flag.

Thanks,
Tomoki Sekiyama

    