On 12/12/2014 at 05:20 PM, in message <548AB36E.30808@redhat.com>, Peter Krempa <pkrempa@redhat.com> wrote: On 12/12/14 10:04, Chunyan Liu wrote: Signed-off-by: Chunyan Liu <cyliu@suse.com>
src/remote/remote_driver.c | 2 +- src/remote/remote_protocol.x | 13 ++++++++++++- 2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 999f16d..97ea64b 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -7941,7 +7941,6 @@ remoteDomainGetFSInfo(virDomainPtr dom, return rv; }
-
Spurious whitespace change.
/* get_nonnull_domain and get_nonnull_network turn an on-wire * (name, uuid) pair into virDomainPtr or virNetworkPtr object. * These can return NULL if underlying memory allocations fail, @@ -8285,6 +8284,7 @@ static virHypervisorDriver hypervisor_driver = { .connectGetAllDomainStats = remoteConnectGetAllDomainStats, /* 1.2.8 */ .nodeAllocPages = remoteNodeAllocPages, /* 1.2.9 */ .domainGetFSInfo = remoteDomainGetFSInfo, /* 1.2.11 */ + .domainSendSysrq = remoteDomainSendSysrq, /* 1.2.11 */
We are now in freeze for 1.2.11, and thus won't take new features. This needs to change to 1.2.12.
Thanks, will update.
};
static virNetworkDriver network_driver = { diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index cbd3ec7..d988182 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -1084,6 +1084,11 @@ struct remote_domain_send_key_args { unsigned int flags; };
+struct remote_domain_send_sysrq_args { + remote_nonnull_domain dom; + remote_nonnull_string key;
Flags argument needs to be added
Thanks, will update.
+}; + struct remote_domain_send_process_signal_args { remote_nonnull_domain dom; hyper pid_value; @@ -5550,5 +5555,11 @@ enum remote_procedure { * @generate: none * @acl: domain:fs_freeze */ - REMOTE_PROC_DOMAIN_GET_FSINFO = 349 + REMOTE_PROC_DOMAIN_GET_FSINFO = 349, + + /** + * @generate: both + * @acl: domain:send_input + */ + REMOTE_PROC_DOMAIN_SEND_SYSRQ = 350 };
Missing change to remote_protocol-structs. Did you run syntax-check?
Yes. And I tested the command through 'virsh -c xen+ssh:// to a remote host', then 'sysrq', it works. It still needs to change remote_protocol-strcuts?
Peter