Re: [Libvir] 1/4 Additions to the public API

On Thu, Feb 21, 2008 at 08:56:17PM +0000, Richard W.M. Jones wrote: > This just adds the four new functions to the public API. [...] > +/** > + * virNetworkDHCPHostMapping: > + * > + * hostname mappings are returned by virNetworkListDHCPHostMapping. > + */ > +typedef struct _virNetworkDHCPHostMapping { > + char *hwaddr; > + char *ipaddr; > + char *hostname; > +} virNetworkDHCPHostMapping; > + > +typedef virNetworkDHCPHostMapping *virNetworkDHCPHostMappingPtr; > + [...] > +int virNetworkListDHCPHostMappings > + (virNetworkPtr network, > + virNetworkDHCPHostMappingPtr *const mappings, > + int maxmappings); > +int virNetworkFreeDHCPHostMappings > + (virNetworkDHCPHostMappingPtr *const mappings, > + int maxmappings); Hum, do we really need to expose this structure at the API level, since we use it only for listing. Since everything is provided as strings why not use something like int virNetworkListDHCPHostMappings (virNetworkPtr network, int maxmappings, char **hwaddrtab, char **ipaddrtab, char **hostnametab); This also avoids the free function too, same functionality, quite a simpler interface.