Re: [libvirt] [PATCH v2 5/7] virNetDevMacVLanTapSetup: Allow enabling of IFF_MULTI_QUEUE
On Mon, 2015-12-14 at 12:35 +0100, Michal Privoznik wrote:
On 14.12.2015 11:23, Ian Campbell wrote:
> Hello,
>
> On Thu, 2015-12-10 at 08:38 +0100, Michal Privoznik wrote:
> > Like we are doing for TUN/TAP devices, we should do the same for
> > macvtaps. Although, it's not as critical as in that case, we
> > should do it for the consistency.
> >
> > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
>
> This has triggered a build failure on amd64+i386+armhf within the Xen
> automated test framework (which uses Debian Wheezy as the build
> environment), I doubt it is in any way Xen specific though:
>
> util/virnetdevmacvlan.c: In function 'virNetDevMacVLanTapSetup':
> util/virnetdevmacvlan.c:338:26: error: 'IFF_MULTI_QUEUE' undeclared
> (first use in this function)
> util/virnetdevmacvlan.c:338:26: note: each undeclared identifier is
> reported only once for each function it appears in
>
this is supposed to be fixed by:
Ah, I somehow missed that commit in the logs, sorry.
The test run in question had picked up afe73ed46856 which was before the
fixup, the next one will pickup the newer version and be fine.
Thanks and sorry for the noise.
Ian.
commit ec93cc25ecdad100a535cb52c08f7eaa3004b960
Author: Michal Privoznik <mprivozn(a)redhat.com>
AuthorDate: Sat Dec 12 08:05:17 2015 +0100
Commit: Michal Privoznik <mprivozn(a)redhat.com>
CommitDate: Sun Dec 13 08:35:46 2015 +0100
virNetDevMacVLanTapSetup: Work around older systems
Some older systems, e.g. RHEL-6 do not have IFF_MULTI_QUEUE flag
which we use to enable multiqueue feature. Therefore one gets the
following compile error there:
CC util/libvirt_util_la-virnetdevmacvlan.lo
util/virnetdevmacvlan.c: In function 'virNetDevMacVLanTapSetup':
util/virnetdevmacvlan.c:338: error: 'IFF_MULTI_QUEUE' undeclared
(first use in this function)
util/virnetdevmacvlan.c:338: error: (Each undeclared identifier is
reported only once
util/virnetdevmacvlan.c:338: error: for each function it appears in.)
make[3]: *** [util/libvirt_util_la-virnetdevmacvlan.lo] Error 1
So, whenever user wants us to enable the feature on such systems,
we will just throw a runtime error instead.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
Michal