On 12/23/2010 12:25 PM, Matthias Bolte wrote:
2010/12/22 Eric Blake <eblake(a)redhat.com>:
> * src/qemu/qemu_capabilities.h (QEMUD_CMD_FLAG_MIGRATE_QEMU_FD):
> New enum value.
> * src/qemu/qemu_capabilities.c (qemuCapsComputeCmdFlags): Populate
> flags according to qemu version.
> * tests/qemuhelptest.c (mymain): Adjust test.
> ---
>
> I feel a bit dirty relying on just a version test for whether
> -incoming fd:n is supported, but it's no different than the
> existing code for -incoming unix:path which was added about the
> same time. Unfortunately, 'qemu -help' doesn't list which
> particular protocols it supports for -incoming.
>
> src/qemu/qemu_capabilities.c | 6 +++++-
> src/qemu/qemu_capabilities.h | 1 +
> tests/qemuhelptest.c | 12 ++++++++----
> 3 files changed, 14 insertions(+), 5 deletions(-)
>
ACK.
Thanks; pushed. I've now done actual migration testing with patches 2
and 3 in place, and was pleased that it worked without having to make
any more modifications, so feel free to review those as well.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org