
12 Mar
2024
12 Mar
'24
5:57 a.m.
On Tue, Mar 12, 2024 at 00:11:28 +0200, Mostafa wrote: The patch looks good now, but you've used multiple names in various fields over the two postings and the preference in terms of both authorship and sign-off is to use a full real name Used previously:
From: مصطفي محمود كمال الدين <48567303+moste00@users.noreply.github.com> From: m kamal <recenum@outlook.com>
The one in this patch:
Signed-off-by: Mostafa <recenum@outlook.com>
I don't want to assume anything about foreign names, but the last one looks more like a nickname or given name only.
--- src/libvirt-domain.c | 32 ++++++++------------------------ 1 file changed, 8 insertions(+), 24 deletions(-)
For the code: Reviewed-by: Peter Krempa <pkrempa@redhat.com>