Re: [libvirt] [PATCH 2/2]: Call udevsettle in the appropriate places

28 Nov 2008

      Daniel P. Berrange wrote:
...
This seems rather overkill when you could just do
#if defined(UDEVADM) || defined(UDEVSETTLE)
void virStorageBackendWaitForDevices(virConnectPtr conn)
{
#ifdef UDEVADM
    const char *const settleprog[] = { UDEVADM, "settle", NULL };
#else
    const char *const settleprog[] = { UDEVSETTLE, NULL };
#endif
    int exitstatus;
Well, I didn't do that originally because of the access() check, which would
also have needed to use #ifdef.  But I just realized I should be able to do:

if (access(settleprog[0], X_OK) != 0)
    return;

And be good.  So I'll respin the patch like you say above and with this fix in
place.

-- 
Chris Lalancette