Re: [libvirt] [PATCH] conf: don't check hyperv spinlock retries if disabled

On Thu, Jul 04, 2013 at 13:40:42 +0200, Jano Tomko wrote: > <hyperv> > <spinlocks state='off'/> > </hyperv> > > results in: > error: XML error: missing HyperV spinlock retry count > > Don't require retries when state is off and use virXPathUInt > instead of virXPathString to simplify parsing. > > https://bugzilla.redhat.com/show_bug.cgi?id=784836#c19 > --- > docs/schemas/domaincommon.rng | 8 ++++-- > src/conf/domain_conf.c | 32 +++++++++------------- > .../qemuxml2argvdata/qemuxml2argv-hyperv-off.args | 4 +++ > tests/qemuxml2argvdata/qemuxml2argv-hyperv-off.xml | 29 ++++++++++++++++++++ > tests/qemuxml2argvtest.c | 1 + > tests/qemuxml2xmltest.c | 1 + > 6 files changed, 53 insertions(+), 22 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hyperv-off.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hyperv-off.xml ACK Jirka