Re: [libvirt] [PATCH] "static" ip address

On Tue, Aug 12, 2008 at 05:24:01PM -0400, Daniel Veillard wrote: > New patch with just a pair of minor fixes which seems to work just fine for > me. The syntax is nearly the old one, just use host instead of statichost: > > <ip address="192.168.122.1" netmask="255.255.255.0"> > <dhcp> > <range start="192.168.122.4" end="192.168.122.254" /> > <host mac="00:16:3E:XX:XX:XX" host="XXX" Seems a little odd to have 'host' as the element name and attribute name at once. Perhaps the atribute should just be name='XXXX' ?

> @@ -1103,6 +1103,8 @@ > 2 + /* --listen-address 10.0.0.1 */ > 1 + /* --dhcp-leasefile=path */ > (2 * network->def->nranges) + /* --dhcp-range 10.0.0.2,10.0.0.254 */ > + /* --dhcp-host 01:23:45:67:89:0a,hostname,10.0.0.3 */ > + (2 * network->def->nhosts) + Using the --dhcp-host option means we can't easily update on the fly, but this patch doesn't support on the fly updates anyway, so not a huge deal. In the future we can switch to --dhcp-host-file instead. ACK to including this.