On 08/20/2012 04:54 PM, Eric Blake wrote:
In preparation for splitting virsh-interface.c, I found these functions need to be declared in virsh.h, as well as one that belongs more properly in virsh-domain.h.
* tools/virsh.h (vshNameSorter, vshCmdHasOption): Declare. (vshCommandOptDomainBy): Move... * tools/virsh-domain.h): ...here. * tools/virsh.c: (vshNameSorter): Export. (cmd_has_option): Rename... (vshCmdHasOption): ...and export. (vshCommandOptDomainBy): Move... * tools/virsh-domain.c (vshCommandOptDomainBy): ...here. * tools/virsh-network.c (vshCommandOptNetworkBy): Update callers. * tools/virsh-nwfilter.c (vshCommandOptNWFilterBy): Likewise. * tools/virsh-secret.c (vshCommandOptSecret): Likewise. * tools/virsh-domain-monitor.c (includes): Likewise. * tools/virsh-host.c (includes): Likewise. --- tools/virsh-domain-monitor.c | 1 + tools/virsh-domain.c | 48 +++++++++++++++++++++++++++++++++++++++ tools/virsh-domain.h | 12 ++++++++++ tools/virsh-host.c | 1 + tools/virsh-interface.c | 2 +- tools/virsh-network.c | 2 +- tools/virsh-nwfilter.c | 2 +- tools/virsh-secret.c | 2 +- tools/virsh.c | 54 +++----------------------------------------- tools/virsh.h | 14 ++---------- 10 files changed, 71 insertions(+), 67 deletions(-)
Code movement and one function renamed. ACK.