On 08/22/2017 10:16 AM, Neal Gompa wrote:
On Mon, Aug 21, 2017 at 11:56 PM, Dawid Zamirski <dzrudy@gmail.com> wrote:
On Thu, 2017-08-03 at 14:34 -0400, Dawid Zamirski wrote:
As per [1], this patch series splits up the large libvirt-php.c into components that (attempts) to resemble the structure of the libvirt project. Each patch successive patch was compile-tested while the whole series was verified with "make check" and a simple custom written PHP script.
Changes from v1 [2]: * rebase on master * include PHP headers in util.h instead of libvirt-php.h this makes header inter-dependencies easier to manage/understand * also test each patch on PHP 5
[1] https://www.redhat.com/archives/libvir-list/2017-June/msg00991.ht ml [2] https://www.redhat.com/archives/libvir-list/2017-August/msg00046. html
ping?
Michal, can we please have this reviewed and merged so that a release could be cut? Since this is rework of the sources, having a release cut after will make it easier for future patch backports.
Michal is out this week on PTO/vacation - he'll be back next week. John