Em qui., 22 de jan. de 2026 às 07:26, Ján Tomko <jtomko@redhat.com> escreveu:
It would be sufficient to summarize this as: Standardize socket family checks
On a Tuesday in 2026, Julio Faracco wrote:
There is a macro
"The macro"
called
Unsure what purpose this word has in this sentence. What else would you refer to a macro by if not by its name.
VIR_SOCKET_ADDR_IS_FAMILY that checks the socket family.
I think it's named propely enough to not have to spell out its function.
There are several occurrences of raw checks in libvirt code. This commit
just
I have no idea what this word is supposed to mean in this sentence. It feels completely out of place.
In V2, I will rephrase the whole commit message properly.
Should this commit do something else? Is it not enough? I don't think so, a commit should be some logically separate set of changes. If there are more changes to do, they belong in a separate commit.
Ok, let me split up this commit in separate changes.
standardizes the socket family checks by using its macro.
Whose macro?
Jano
Signed-off-by: Julio Faracco <jcfaracco@gmail.com> ---
-- Julio