Re: [libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard
On Thu, Apr 26, 2018 at 18:00:15 +0200, Michal Privoznik wrote:
On 04/26/2018 02:56 PM, Ján Tomko wrote:
> On Fri, Apr 20, 2018 at 11:09:31AM +0200, Michal Privoznik wrote:
[...]
So what was the showstopper for this patch? I wanted to get this in
upcoming release (and freeze is tomorrow). And having v5 for something
trivial like this sounds unbelievable.
I don't think that this tone is warranted. Even if you would get an
ACK/rb for this patch you would not make it into the release. The review
was sent 24 seconds _after_ the release-candidate was tagged:
Date: Thu, 26 Apr 2018 14:56:58 +0200
Subject: Re: [libvirt] [PATCH v4 5/5] qemu: Introduce memoryBacking/discard
tag v4.3.0-rc1
TaggerDate: Thu Apr 26 14:56:34 2018 +0200
which was announced on the mailing list 15 minutes later.
Date: Thu, 26 Apr 2018 15:12:05 +0200
Subject: [libvirt] Entering freeze for libvirt-4.3.0
While I don't want to question your supernatural patch-fixing skill,
fixing the typos and the mailing list delay would easily consume the 15
minutes until the freeze was announced. And it could be even less than
that as the tag was probably pushed prior to sending the anouncement.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)