On 2/10/19 6:09 AM, Roman Bogorodskiy wrote:
Implement the MSRs ignore unknown reads and writes feature
that's specified using:
<features>
...
<msrs unknown='ignore'>
...
</features>
in the domain XML.
In bhyve, it's just passing '-w' command line argument to the bhyve(8)
executable.
Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com>
---
docs/drvbhyve.html.in | 22 ++++++++++++
src/bhyve/bhyve_command.c | 4 +++
.../bhyvexml2argvdata/bhyvexml2argv-msrs.args | 10 ++++++
.../bhyvexml2argv-msrs.ldargs | 3 ++
.../bhyvexml2argvdata/bhyvexml2argv-msrs.xml | 26 ++++++++++++++
tests/bhyvexml2argvtest.c | 1 +
.../bhyvexml2xmlout-msrs.xml | 36 +++++++++++++++++++
tests/bhyvexml2xmltest.c | 1 +
8 files changed, 103 insertions(+)
create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-msrs.args
create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-msrs.ldargs
create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-msrs.xml
create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-msrs.xml
diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in
index 2e9cf5551b..97f6f1b900 100644
--- a/docs/drvbhyve.html.in
+++ b/docs/drvbhyve.html.in
@@ -462,6 +462,23 @@ Example:</p>
</domain>
</pre>
+<h3><a id="msrsignorewrites">Ignoring unknown MSRs
writes</a></h3>
+
+<p>Some guests might require ignoring unknown Model Specific Registers (MSRs)
+reads and writes.
+<span class="since">Since 5.1.0</span> it's possible to switch
this on using:</p>
+<pre>
+<domain type="bhyve">
+ ...
+ <features>
+ <msrs unknown='ignore'/>
+ </features>
+ ...
+</domain>
+</pre>
+
+<p>By default unknown reads and writes are not ignored.</p>
+
Hmm. I think think this should go into domainformat.html.in with a note
that it's currently only implemented for bhyve, and not bhyve specific
docs. That's the pattern we follow for the qemu driver
<h3><a id="bhyvecommand">Pass-through of
arbitrary bhyve commands</a></h3>
<p><span class="since">Since 5.1.0</span>, it's possible
to pass additional command-line
@@ -489,5 +506,10 @@ They are <b>unsupported</b>, using them may result in
inconsistent state,
and upgrading either bhyve or libvirtd maybe break behavior of a domain that
was relying on a specific commands pass-through.</p>
+
+>>>>>>> 525918ac5c... bhyve: implement MSRs ignore unknown writes
feature
+=======
+>>>>>>> 93d9056998... fixup! bhyve: implement MSRs ignore unknown
writes feature
+
Something went wrong here. Feel to just fix those issues and push
Reviewed-by: Cole Robinson <crobinso(a)redhat.com>
- Cole