On Wed, 2019-06-19 at 16:11 +0200, Martin Kletzander wrote: [...]
simpleSearch = document.getElementById("simplesearch") - simplesearch.addEventListener("submit", advancedsearch) + simpleSearch.addEventListener("submit", advancedsearch)
If I'm not mistaken, this is an unrelated bugfix. If that's the case, then it should be its own patch. [...]
+ script = document.createElement("script") + script.src = "https://feedrapp.herokuapp.com/" + script.src += `?q=http%3A%2F%2Fplanet.virt-tools.org%2Fatom.xml&callback=${cb}`
Any way we can have the RSS URL as a plain string that we urlencode and combine with the feedrapp URL at runtime? That'd be a bit more readable I reckon. Other than these two nits, and with the caveat that I have close to zero JavaScript knowledge so I might have overlooked even serious issues with your implementation :), I *overwhelmingly* love this. Let's see whether anyone spots any blockers, but otherwise I'd say polish it up, post it as non-RFC, collect my ACK and get it merged as soon as humanly possible! -- Andrea Bolognani / Red Hat / Virtualization