Re: [libvirt PATCH 02/10] qemu: eliminate ret variable in qemuExtTPMStartEmulator
On Tue, Jan 28, 2020 at 11:31:18 +0100, Ján Tomko wrote:
Now that the cleanup section is empty, eliminate the cleanup
label as well as the 'ret' variable.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
src/qemu/qemu_tpm.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
It's a shame this code uses hand-rolled waiting loop for the process
rather than the backoff timer.
Also would be great to get rid of the error label too.
But those comments are out of scope of this patch thus:
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>