Re: [libvirt] [libvirt-glib 3/3] gconfig: Add GVirConfigDomainSnapshot getters/setters

On Thu, May 02, 2013 at 06:33:44PM +0300, Zeeshan Ali (Khattak) wrote: Ah, I knew I still had something to fix somewhere before sending this series, I just couldn't remember what, thanks! However, I'm not sure I'll go with a separate object, the doc says: "memory On input, this is an optional request for how to handle VM memory state. For an offline domain or a disk-only snapshot, attribute snapshot must be no, since there is no VM state saved; otherwise, the attribute can be internal if the memory state is piggy-backed with other internal disk state, or external along with a second attribute file giving the absolute path of the file holding the VM memory state. Since 1.0.1" This would mean GVirConfigDomainSnapshotMemoryNone, GVirConfigDomainSnapshotMemoryInternal and GVirConfigDomainSnapshotMemoryExternal classes so that we can expose the file attribute only on the last of these classes. The MemoryNone class seems a bit weird to me, and 3 classes to make an attribute optional sounds a bit overkill. I think I'll go with gvir_config_domain_snapshot_get_memory(); and gvir_config_domain_snapshot_get_memory_file(); which will return NULL unless the snapshot type is external. Ok! Hmm, that's a good point, this is made a bit tricky because of the "Older versions of libvirt stored only a single child element, uuid". This was changed in 2011 for libvirt 0.9.5 by http://libvirt.org/git/?p=libvirt.git;a=commit;h=f609cb85ca11d6d178972e46... Given that we already require libvirt 0.10.2, I'd say it's fine to ignore this 'older version' case. Christophe