On 09/22/2015 04:40 PM, Eric Blake wrote:
On 09/22/2015 01:57 PM, Cole Robinson wrote:
$ rpmbuild -ba libvirt.spec warning: Macro expanded in comment on line 5: # If neither fedora nor rhel was defined, try to guess them from %{dist}
warning: Macro %enable_autotools defined but not used within scope warning: Macro %client_only defined but not used within scope ... --- libvirt.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
# Default to skipping autoreconf. Distros can change just this one line # (or provide a command-line override) if they backport any patches that # touch configure.ac or Makefile.am. -%{!?enable_autotools:%define enable_autotools 0} +%{!?enable_autotools:%global enable_autotools 0}
I guess %global works. I might have tried:
%if !0%{?enable_autotools} %define enable_autotools 0 %endif
but that's longer.
ACK
Thanks, pushed now - Cole