On Mon, Oct 08, 2012 at 15:55:09 +0100, Daniel P. Berrange wrote:
My feeling is that we came to agreement with the QEMU developers that we would exclusively useful QMP probing with any QEMU from 1.2.0 or later and would not try to follow changes they make to the non-QMP interfaces we previously relied on. So if there are any changes to -help, -cpu, -M or -device output from 1.2.0 onwards, we really should not try to follow them in libvirt master.
I could see this patch being acceptable for our newest stable release stream branch though. Traditionally our requriement was that patches for stable should go in master first, but I think this scenario is an example where we should relax that rule and put the change in the stable branch only.
Although it will only help if someone updates QEMU while staying on a stable libvirt branch. I'm not saying it's a bad idea, though :-) Can I take this as an ACK for pushing into the stable branch? Jirka