On Mon, Jan 6, 2020 at 6:22 PM Peter Krempa <pkrempa@redhat.com> wrote:
On Mon, Jan 06, 2020 at 11:11:01 +0100, Peter Krempa wrote:
> On Wed, Jan 01, 2020 at 13:06:33 +0800, Han Han wrote:
> > Since v4.2-rc0, QEMU introduced a builtin rng backend that uses
> > getrandom() syscall to generate random. Add it to libvirt with the
> > backend model 'builtin'.
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1785091
> >
> > Signed-off-by: Han Han <hhan@redhat.com>
> > ---
> >  src/conf/domain_audit.c |  2 ++
> >  src/conf/domain_conf.c  |  9 +++++++++
> >  src/conf/domain_conf.h  |  1 +

Additionally this patch mixes XML additions (the enum value addition and
corresponding conversion string and qemu implementation. We prefer if
it's not mixed.

OK. I will split it into 2 patches.


--
Best regards,
-----------------------------------
Han Han
Quality Engineer
Redhat.

Email: hhan@redhat.com
Phone: +861065339333