On Tue, Sep 14, 2010 at 02:52:13PM +0200, Gerhard Stenzel wrote:
On Fri, 2010-09-10 at 16:02 +0200, Gerhard Stenzel wrote:
> Sounds good and I will give it a try ...
All my tests worked except scripts/nwfilter/210-no-mac-spoofing.t, which
failed with on Fedora 13:
...
# ' > /test.sh
input must be 8 bytes long at /usr/lib64/perl5/Crypt/DES.pm line 57.
# Looks like you planned 4 tests but ran 3.
...
Hmm, yes I see that same problem.
Here is the patch, that fixes the problem for me:
diff --git a/scripts/nwfilter/210-no-mac-spoofing.t
b/scripts/nwfilter/210-no-mac-spoofing.t
index df47fd7..2906e1f 100644
--- a/scripts/nwfilter/210-no-mac-spoofing.t
+++ b/scripts/nwfilter/210-no-mac-spoofing.t
@@ -25,6 +25,7 @@ The test case validates that MAC spoofing is prevented
use strict;
use warnings;
+use utf8;
use Test::More tests => 4;
@@ -94,6 +95,7 @@ my $cmdfile = "echo '" .
"/sbin/ifconfig eth0 up\n".
"/sbin/ifconfig eth0\n".
"' > /test.sh";
+utf8::encode ($cmdfile);
This is bizarre - I don't see any characters in the $cmdfile
string that are above ASCII-7 range, so should be identical
whether its utf8 encoded or not !?!? Do you know why this
makes it work correctly ?
Daniel
--
|: Red Hat, Engineering, London -o-
http://people.redhat.com/berrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org -o-
http://deltacloud.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|