Re: [libvirt] [PATCH v3] deprecate fclose() and introduce VIR_{FORCE_}FCLOSE()

On 11/16/2010 04:50 AM, Stefan Berger wrote:

V3: - fixes from V2 review + one lost hunk

-> diff(tree+V2, tree+v3) at bottom of email

That helps. And you solved all my findings. ACK.

+++ src/xen/xen_driver.c 2010-11-16 06:31:49.722481846 -0500 @@ -218,9 +218,9 @@ #endif #ifdef __sun int fd;

- if (fd = open("/dev/xen/domcaps", O_RDONLY)) { + if ((fd = open("/dev/xen/domcaps", O_RDONLY))>= 0) {

Did you want a space before >=? -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org