Re: [libvirt PATCH 6/7] qemu_snapshot: correctly load the saved memory state file

On Thu, Aug 31, 2023 at 16:55:05 +0200, Pavel Hrdina wrote:

Original code assumed that the memory state file is only migration stream but it has additional metadata stored by libvirt. To correctly load the memory state file we need to reuse code that is used when restoring domain from saved image.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- src/qemu/qemu_snapshot.c | 78 ++++++++++++++++++++++++---------------- 1 file changed, 47 insertions(+), 31 deletions(-)

This one is indeed cleaner. Note my comments about the save image cookie though. Reviewed-by: Peter Krempa <pkrempa@redhat.com>