On 01/05/2012 10:23 PM, Richard W.M. Jones wrote:
On Wed, Jan 04, 2012 at 12:09:18PM +0800, Lai Jiangshan wrote:
+int virDomainGetPcpusUsage(virDomainPtr dom, + unsigned long long *usages, + int *nr_usages, + unsigned int flags);
It'd be useful to get feedback from libvirt folk about whether this API is reasonable.
+/** + * virDomainGetPcpusUsage: + * @dom: pointer to domain object + * @usages: returned physic cpu usages
'physical'
+ * @nr_usages: length of @usages + * @flags: flags to control the operation + * + * Get the cpu usages per every physic cpu
'physical'
I think this needs to describe what exactly is returned. Nanoseconds since the domain started, I assume?
Yes. I will apply your comments in next version which will be deferred until 0.9.9 released as Eric suggested. Thank you very much. Lai