Re: [PATCH 1/1] scripts: Fix the parameter of warning function
On 3/12/22 08:42, luzhipeng wrote:
---
scripts/apibuild.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index bdd3077c48..99b16f47fa 100755
--- a/scripts/apibuild.py
+++ b/scripts/apibuild.py
@@ -317,7 +317,7 @@ class index:
if type in type_map:
type_map[type][name] = d
else:
- self.warning("Unable to register type ", type)
+ self.warning("Unable to register type %s" % type)
if name == debugsym and not quiet:
print("New symbol: %s" % (d))
Hey, the patch is correct. However, in order to be merged couple of
requirements have to be met:
1) the commit message must contain your Signed-off-by line:
https://libvirt.org/hacking.html#developer-certificate-of-origin
2) speaking of commit message - you should introduce one. If I'd look at
this commit in git log (long after it's been pushed), I would have no
idea what it does and what problem it's fixing. It doesn't have to be
long, in fact the shorter the better. But too short is not good either.
I'm open to make an exception and if you reply to this e-mail with the
commit message and your Signed-off-by line I can amend those and merge.
Michal