21 Feb
2013
21 Feb
'13
8:07 p.m.
On 02/21/2013 08:49 AM, Christophe Fergeau wrote:
It's only freed on normal returns from virDomainVideoDefParseXML, but not when erroring out. --- src/conf/domain_conf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
ACK; your fix is reasonable. A more idiomatic fix might be to coalesce the error and normal exits into a single cleanup: label; in fact, Peter's 16-part series on improving domain_conf.c may have done just that. But as I haven't gotten that far in reviewing his series, and this is a real fix, you can go ahead and push and Peter can deal with any rebase fallout. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org