Re: [libvirt] [PATCH] qemu: blockjob: Call qemuDomainSupportsBlockJobs only on online VMs

On Thu, Apr 30, 2015 at 08:40:56 -0600, Eric Blake wrote:

On 04/30/2015 08:37 AM, Peter Krempa wrote:

...

Since the qemu capabilities are not initialized for offline VMs the caller might get suboptimal error message:

$ virsh blockjob VM PATH --bandwidth 1 error: unsupported configuration: block jobs not supported with this QEMU binary

Move the checks after we make sure that the VM is alive. --- src/qemu/qemu_driver.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-)

ACK; safe enough for freeze

Now pushed; Thanks. Peter