Re: [libvirt] [PATCH 0/8 v5] Summary on block IO throttle

On 11/15/2011 02:02 AM, Lei Li wrote: > Changes since V3 >  - Use virTypedParameterPtr instead of specific struct in libvirt pulic API. >  - Relevant changes to remote driver, qemu driver, python support and virsh. > > To help add QEMU I/O throttling support to libvirt, we plan to complete > it with add new API virDomain{Set, Get}BlockIoThrottle(), new command 'blkdeviotune' > and Python bindings. > > Notes: Now all the planed features were implemented (#1#2 were implemented by > Zhi Yong Wu), the previous comments were all fixed up too. And the qemu part patches > have been accepted upstream and are expected to be part of the QEMU 1.1 > release, git tree from Zhi Yong: > > http://repo.or.cz/w/qemu/kevin.git/shortlog/refs/heads/block I just realized that the block_set_io_throttle monitor command is not yet in released upstream qemu.  I will continue reviewing this series, but it's harder to justify including it into libvirt 0.9.8 unless we have a good feel that the design for qemu is stable and unlikely to

undergo further modifications.  We have included libvirt changes for unreleased qemu features in the past, but only after pointing to qemu list archives documenting that there is large consensus for the proposed design, and that any further changes prior to a qemu release containing the design will be internal only. -- Eric Blake   eblake(a)redhat.com    +1-919-301-3266 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list