Re: [libvirt] [PATCH] Fix virsh sched-credit for xend
On Mon, Jan 26, 2009 at 11:48:42AM +0000, John Levon wrote:
On Mon, Jan 26, 2009 at 11:29:01AM +0000, Daniel P. Berrange wrote:
> It isn't that simple. Tunables are not represented as part of the XML,
Good point, that would need to be fixed. I'd missed this.
> So if we want to be able to set tunables on inactive domains, the
> virDomainSetSchedularParams() is not the right place todo it - we
> can only guarentee that is is reliably usable on live domains.
No, surely we should fix the XML to represent it, and then it /would/
work. Must be better than another identical API.
Historically there has been a bit of a debate about this. It's not
clear if the XML is meant to represent static configuration about the
domain (eg. what disks it has), versus administration of the domain
(how vCPUs are pinned for example).
Is this still a real distinction we can/need to make? Maybe time to
revisit this and allow administrative things to be added.
(BTW I find that the API providing a bunch of unknown name/value
pairs
with no indication of what they might be a little icky...)
Yeah me too.
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
Read my OCaml programming blog: http://camltastic.blogspot.com/
Fedora now supports 68 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora